[Cases] Add Lens markdown plugin by patrykkopycinski · Pull Request #96703 · elastic/kibana

patrykkopycinski · 2021-04-09T16:06:47Z

Summary

Untitled_.Apr.9.2021.7_17.PM.mp4

Design links

Whimsical wireframe
Figma

TODO in the follow up PR:

Support Lens in Add case page
Extract common logic to the package
Support Lens in Timeline notes?
Allow to Open in Lens just for the preview (disable Save button)

…ns-markdown-plugin

stephmilovic · 2021-04-21T18:07:51Z

This looks awesome Patryk! We are going to be merging the cases_rac_ui branch in the coming days. We had to rework how the markdown plugin takes timeline plugin: #96496

It would be awesome if you could either open this PR against that cases_rac_ui branch or wait until we merge. There will be conflicts for sure. @michaelolo24 or I would be happy to help you through it!

patrykkopycinski · 2021-04-21T19:46:31Z

Thank you for the heads up @stephmilovic :)
This PR is more like PoC to start a discussion with Lens/Explorary view team to discuss possible implementation ways for 7.14, so I'd not worry about having it merged anytime soon :)

stephmilovic · 2021-04-22T13:50:00Z

well i cant wait to get it merged, it looks really cool!!

monina-n · 2021-05-28T18:20:13Z

hi! these are my initial comments based only on the video.

Comments:

Visualization lacks a title when added to the case. One idea is to have a title similar to Dashboard styling

Similar comment about the time range. There are timestamps on the X-axis, but it could be helpful to have some type of subtitle so users know at a glance what time range the graph encompasses
Beneficial to discuss flyout vs. modal to make sure we're making the right decision

Clarification:

Is it only one Lens visualization allowed per comment?
Are you able to add additional text in the same comment as the visualization?

…ns-markdown-plugin # Conflicts: # x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/index.ts

stephmilovic · 2021-06-14T16:55:07Z

@elasticmachine merge upstream

Lens Cases UI

…ns-markdown-plugin

stephmilovic · 2021-08-17T14:59:46Z

    });
  });
+
+  describe('extractLensReferencesFromCommentString', () => {


great job on these tests, very helpful

stephmilovic · 2021-08-17T16:19:08Z

+  const [nodePosition, setNodePosition] = useState<EuiMarkdownAstNodePosition | undefined>(
+    undefined
+  );
+  // const [editMode, setEditMode] = useState(!!node);


stephmilovic · 2021-08-17T16:20:17Z

+
+  const savedObjectMetaData = useMemo(
+    () => [
+      {


this all looks static, no props? can move outside of component to a plain const

stephmilovic · 2021-08-17T16:23:11Z

+              </EuiText>
+            </EuiFlexItem>
+            <EuiFlexItem grow={false}>
+              {viewMode && canUseEditor() ? (


i think we can put canUseEditor in a useMemo?

stephmilovic · 2021-08-17T16:23:19Z

+                  isDisabled={!canUseEditor()}
+                  onClick={handleClick}
+                >
+                  {`Open visualization`}


needs i18n

stephmilovic · 2021-08-17T16:24:11Z

+          <EuiSpacer size="xs" />
+
+          <EmbeddableComponent
+            id=""


is this correct?

stephmilovic

Just a few nits and the bugs we discussed over zoom. Remember to add validation to the Visualization Title! LGTM

…ns-markdown-plugin # Conflicts: # x-pack/plugins/security_solution/public/common/components/markdown_editor/editor.tsx

…ns-markdown-plugin

kibanamachine · 2021-08-17T20:29:21Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	263	272	+9
`lens`	805	806	+1
total			+10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	580.8KB	582.8KB	+2.0KB
`lens`	1.7MB	1.7MB	+190.0B
`observability`	489.2KB	489.3KB	+15.0B
`osquery`	2.3MB	2.3MB	+9.0B
`securitySolution`	6.5MB	6.5MB	+951.0B
total			+3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	132.1KB	133.0KB	+882.0B
`lens`	29.6KB	30.0KB	+433.0B
`savedObjects`	52.1KB	52.2KB	+85.0B
total			+1.4KB

Unknown metric groups

API count

id	before	after	diff
`cases`	452	454	+2
`embeddable`	467	468	+1
`lens`	220	246	+26
`observability`	226	227	+1
`savedObjects`	220	221	+1
total			+31

API count missing comments

id	before	after	diff
`cases`	410	412	+2
`embeddable`	391	392	+1
`lens`	202	228	+26
`observability`	226	227	+1
`savedObjects`	206	207	+1
total			+31

async chunk count

id	before	after	diff
`cases`	14	15	+1

Non-exported public API item count

id	before	after	diff
`savedObjects`	5	4	-1

History

💔 Build #146263 failed c2a439f
💚 Build #145701 succeeded 317e7dc
💔 Build #145559 failed 5513a45
💔 Build #145529 failed 7775cb8
💔 Build #145271 failed af3fbe8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

adamwdraper

Summary of sync meeting today between @patrykkopycinski @paulewing @yiyangliu9286 @adamwdraper

Current design as implemented in this pr is not ready to be released as is. It requires iteration of ux to fix UI bugs and align with EUI guidelines. This pr will be merged, but will be behind a feature flag. This feature flag must default to off, unless the new ux is finalized and delivered, and @yiyangliu9286 or @adamwdraper approve the ux matches designs.

Next Steps:

@yiyangliu9286 to make ux adjustments
@yiyangliu9286 to sync with @patrykkopycinski to agree on the final design
@patrykkopycinski will implement finalized ux
@yiyangliu9286 or @adamwdraper signoff before feature flag is enabled

kibanamachine · 2021-08-17T22:52:32Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 96703

yiyangliu9286 · 2021-08-18T15:45:13Z

@patrykkopycinski Please see design followup issue: #109121 (cc: @adamwdraper @paulewing)

# Conflicts: # x-pack/plugins/observability/public/components/shared/exploratory_view/header/header.test.tsx # x-pack/plugins/observability/public/components/shared/exploratory_view/header/header.tsx # x-pack/plugins/observability/public/plugin.ts

patrykkopycinski added 6 commits March 23, 2021 23:37

[Cases] Add Lens markdown plugin

d1d567f

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

18e90b4

…ns-markdown-plugin

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

77edc5b

…ns-markdown-plugin

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

601aaaa

…ns-markdown-plugin

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

44b89fb

…ns-markdown-plugin

cleanup

4b46590

patrykkopycinski added release_note:enhancement v8.0.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed Feature:Cases-RAC-UI labels Apr 9, 2021

patrykkopycinski self-assigned this Apr 9, 2021

cleanup

7d49b2d

patrykkopycinski requested a review from XavierM April 9, 2021 17:23

cnasikas reviewed Apr 12, 2021

View reviewed changes

Comment thread ...ck/plugins/security_solution/public/common/components/markdown_editor/plugins/lens/parser.ts Outdated

cnasikas reviewed Apr 12, 2021

View reviewed changes

Comment thread ...k/plugins/security_solution/public/common/components/markdown_editor/plugins/lens/plugin.tsx Outdated

patrykkopycinski removed the v7.13.0 label Apr 14, 2021

patrykkopycinski and others added 4 commits May 29, 2021 20:38

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

8436ff6

…ns-markdown-plugin # Conflicts: # x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/index.ts

Merge 8436ff6 into 0993a1c

df69565

add lens to cases

60146c5

remove comments

ab71519

kibanamachine and others added 4 commits June 14, 2021 12:55

Merge branch 'master' into feat/cases-lens-markdown-plugin

6ff1f5c

Merge pull request #5 from stephmilovic/lens_cases

3aef8c6

Lens Cases UI

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

f1060bc

…ns-markdown-plugin

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

1c1cc05

…ns-markdown-plugin

stephmilovic reviewed Aug 17, 2021

View reviewed changes

stephmilovic approved these changes Aug 17, 2021

View reviewed changes

patrykkopycinski added 2 commits August 17, 2021 18:59

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

c2a439f

…ns-markdown-plugin # Conflicts: # x-pack/plugins/security_solution/public/common/components/markdown_editor/editor.tsx

Merge branch 'master' of github.com:elastic/kibana into feat/cases-le…

2565f05

…ns-markdown-plugin

patrykkopycinski enabled auto-merge (squash) August 17, 2021 21:17

adamwdraper reviewed Aug 17, 2021

View reviewed changes

adamwdraper self-requested a review August 17, 2021 22:48

adamwdraper approved these changes Aug 17, 2021

View reviewed changes

patrykkopycinski merged commit 754b79f into elastic:master Aug 17, 2021

patrykkopycinski mentioned this pull request Aug 18, 2021

[7.x] [Cases] Add Lens markdown plugin (#96703) #109071

Merged

yiyangliu9286 mentioned this pull request Aug 18, 2021

[Cases] Add Lens markdown plugin followup UX changes #109121

Closed

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Aug 18, 2021

[Cases] Add Lens markdown plugin (elastic#96703)

5968a2c

patrykkopycinski mentioned this pull request Aug 18, 2021

[7.15] [Cases] Add Lens markdown plugin (#96703) #109148

Merged

patrykkopycinski added a commit that referenced this pull request Aug 18, 2021

[Cases] Add Lens markdown plugin (#96703) (#109148)

46461a4

patrykkopycinski mentioned this pull request Aug 24, 2021

[Cases] Fix add Lens markdown plugin UX #109178

Merged

patrykkopycinski deleted the feat/cases-lens-markdown-plugin branch August 24, 2021 00:17

patrykkopycinski removed the 7.15 candidate label Aug 24, 2021

nastasha-solomon mentioned this pull request Sep 8, 2021

[DOCS] Lens Visualization Plugin Available for Cases elastic/security-docs#1017

Closed

dej611 mentioned this pull request Nov 23, 2021

[Case] Markdown table is not correctly migrated to newer version of Kibana after 7.14 #119509

Closed

nreese mentioned this pull request Feb 14, 2022

[Maps] Extract/inject references from server side embeddable #124976

Closed

patrykkopycinski mentioned this pull request Feb 16, 2023

[Cases] Unify SavedObjectFinderUi component #151491

Merged

Conversation

patrykkopycinski commented Apr 9, 2021 • edited by yiyangliu9286 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design links

Uh oh!

Uh oh!

Uh oh!

stephmilovic commented Apr 21, 2021

Uh oh!

patrykkopycinski commented Apr 21, 2021

Uh oh!

stephmilovic commented Apr 22, 2021

Uh oh!

monina-n commented May 28, 2021

Uh oh!

stephmilovic commented Jun 14, 2021

Uh oh!

stephmilovic Aug 17, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Aug 17, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Aug 17, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Aug 17, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Aug 17, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Aug 17, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 17, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

API count missing comments

async chunk count

Non-exported public API item count

History

Uh oh!

adamwdraper left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 17, 2021

💔 Backport failed

Uh oh!

yiyangliu9286 commented Aug 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

patrykkopycinski commented Apr 9, 2021 •

edited by yiyangliu9286

Loading